-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
82 feature request suggestion create GitHub actions workflow for automating the build and deployments for feature branches #87
Open
lmcdonough
wants to merge
73
commits into
main
Choose a base branch
from
82-feature-request-suggestion-create-github-actions-workflow-for-automating-the-build-and-deployments-for-feature-branches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
82 feature request suggestion create GitHub actions workflow for automating the build and deployments for feature branches #87
lmcdonough
wants to merge
73
commits into
main
from
82-feature-request-suggestion-create-github-actions-workflow-for-automating-the-build-and-deployments-for-feature-branches
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
2461703
to
13a682f
Compare
jhodapp
reviewed
Feb 16, 2025
jhodapp
reviewed
Feb 16, 2025
2415efa
to
eb1d6b4
Compare
… with updated actions, improved environment variable handling, and added artifact attestations for images.
…tHub Actions workflow details
…tructure - Change base image in Dockerfile to rust:1.70-slim - Use environment variable for backend port in Dockerfile - Update volume paths in docker-compose to point to the docs directory - Specify build target in docker-compose for runtime - Adjust frontend build context in docker-compose
…tform support and cleanup
…ed port from 8000 to 4000
…se image from ghcr instead of build
6f5ba61
to
91bc521
Compare
jhodapp
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Levi, a couple more changes requested.
adds badge for container build status to readme.
jhodapp
requested changes
Apr 12, 2025
Comment on lines
+56
to
+59
TIPTAP_URL="https://ok01532m.collab.tiptap.cloud" # URL for the TipTap service | ||
TIPTAP_AUTH_KEY="6122462e59d7cc8c6146f4e3b5c93dfad28c8a219838df69b59ffcec4cdc0041" | ||
# Authentication key for TipTap | ||
TIPTAP_JWT_SIGNING_KEY="0f38cb0650a8fc262258ad415f25c52579bfc4095b222f486557d24c8fafaeb8" # JWT signing key for TipTap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmcdonough Please remove these keys and the URL. You can use empty strings here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow to build and deploy Docker containers for Rust and Next.js projects. The workflow includes steps for building, testing, and pushing Docker images to the GitHub Container Registry.
GitHub Issue: Closes #82
Changes
.github/workflows/build_and_deploy_containers.yml
to automate the build and deployment process for feature branches and pull requests to the main branch.build_test_run
for building and testing the project, andbuild_and_push_docker
for building and pushing Docker images. The latter job depends on the successful completion of the former.seaORM CLI
, build the project, and run tests.Testing Strategy
workflow_dispatch
to iterate and view any errors from the workflow run.Concerns